-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add imgui 1.74 #625
Add imgui 1.74 #625
Conversation
All green! 😊
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The CMake file is better than that one in VCPKG: https://github.com/microsoft/vcpkg/blob/master/ports/imgui/CMakeLists.txt
Co-Authored-By: Uilian Ries <uilianries@gmail.com>
All green in build 2 (
|
All green in build 3 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to clarify the usage of the CMakeLists.txt file, it it needed to build the bindings?
688d04d
All green in build 5 (
|
imgui does not provide any associated build script. It delegates the task of compiling the library to their users.
So the Then the platform backends are provided to the user inside the
I don't know if this is up to conan-center-index standards but at least this is how it is done in the bincrafters recipy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cmakefile loooks compatible with other package managers
Specify library name and version: imgui/1.74 https://github.com/ocornut/imgui
conan-center hook activated.
Recipy based on https://github.com/bincrafters/conan-imgui
Tested on a Ubuntu 18.04. Also tested modifying conan-examples/libs/dear-imgui (had to change the imports from
misc
tores
)