libpng: fix cross-build to iOS arm + cache cmake + modernize #6285
Conversation
when NEON is enable for iOS builds, there are missing symbols in generated lib
we don't package this file in CCI
recipes/libpng/all/conanfile.py
Outdated
| cmake.definitions["CMAKE_SYSTEM_PROCESSOR"] = "aarch64" | ||
| cmake.configure() | ||
| return cmake | ||
| self._cmake.definitions["PNG_BUILD_ZLIB"] = "ON" |
There was a problem hiding this comment.
Does this mean a vendored zlib is built by libpng when building for emscripten?
There was a problem hiding this comment.
Looks like no zlib is used at all:
https://github.com/glennrp/libpng/blob/a37d4836519517bdce6cb9d956092321eca3e73b/CMakeLists.txt#L38-L45
There was a problem hiding this comment.
yes, maybe there was an issue with Emscripten in conan long time ago.
It's the same thing for M_LIBRARY, it's useless to force empty value, it is overridden by upstream anyway.
There was a problem hiding this comment.
There is a pr on cci for emscripten at #6163
Once it gets merged, some recipes should be tested with it.
|
All green in build 4 (
|
|
All holes are covered now. 😝 |
| self._cmake.definitions["PNG_DEBUG"] = self.settings.build_type == "Debug" | ||
| if tools.is_apple_os(self.settings.os): | ||
| if "arm" in self.settings.arch: | ||
| # FIXME: Neon should work on iOS (but currently if leads to undefined symbols), see if autotools build is better |
There was a problem hiding this comment.
| # FIXME: Neon should work on iOS (but currently if leads to undefined symbols), see if autotools build is better | |
| # FIXME: Neon should work on iOS (but currently it leads to undefined symbols), see if autotools build is better |
There was a problem hiding this comment.
yes I saw that after pushing the last commit, but was too lazy to fix the typo 😩
…dernize * fix undefined symbols in iOS arm builds when NEON is enable for iOS builds, there are missing symbols in generated lib * cleanup imports * no os.rename * reorder methods * conventions * cache cmake * declare patch files in conandata.yml * use find_package() in test_package * cleanup * use pure C test package * explicit pkg_config name * remove useless patch in .pc file we don't package this file in CCI * consistent quotes * empty string api_prefix default value * debug output for Debug build_type only * use boolean for CMake options * add comment about iOS build and Neon * remove Emscripten specific stuff
Specify library name and version: lib/1.0
closes #2366
conan-center hook activated.