Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wayland-protocols] Add recipe #6946

Merged
merged 3 commits into from
Aug 23, 2021

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Aug 21, 2021

Specify library name and version: wayland-protocols

closes #3663

#include <wayland-client.h>
#include "xdg-shell-client-protocol.h"

// TODO: Need help to write actual test here
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anyone can help to write a test here that uses it... or maybe use a different protocol

@conan-center-bot

This comment has been minimized.

@ericLemanissier
Copy link
Contributor

Is it the same as #3663 ?

@ghost
Copy link

ghost commented Aug 21, 2021

I detected other pull requests that are modifying wayland-protocols/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Aug 21, 2021
4 tasks
@jgsogo
Copy link
Contributor Author

jgsogo commented Aug 21, 2021

Is it the same as #3663 ?

Oops! Yes, it is the same package, I didn't realize about it.

This approach is slightly different (using Meson) and this test_package is doing more things. I'm fine pushing forward any of these PRs.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 3 (a916efe9e12f50f3b981bdce4fa84ba38f4fb286):

  • wayland-protocols/1.21@:
    All packages built successfully! (All logs)

@jgsogo jgsogo marked this pull request as ready for review August 21, 2021 12:11
homepage = "https://gitlab.freedesktop.org/wayland/wayland-protocols"
license = "MIT"

settings = "os", "arch", "compiler", "build_type"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need these settings for generating xml files ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of them are required by Meson. Anyway, it is declared as header_only so only one package is generated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jgsogo jgsogo requested review from SSE4 and danimtb August 22, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants