Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add co/2.0.2 #7510
add co/2.0.2 #7510
Changes from all commits
2a8ab79
16583bf
be79f6b
c9d9362
0fd268b
13f9371
cfd6c40
ceca037
29eb58a
b71de7c
ffe8570
49d4aaa
3ad6edb
86aa76d
e28fce9
2c8ceba
4706fb2
78edc30
fcc3fb5
6324731
b773395
1ea10d1
93cee24
e90259b
bbf6c85
8859d8f
b0b4231
b8bf117
94d026a
3c4fe47
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we fine with
co
?Perhaps it 's safer to namespace it?
idealvin-co
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, CO is very generic abbreviation, it may stand for Cobalt, Carbon Oxide, programming language, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mendeleev sent a hi! ⚗️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About months ago, vcpkg said that the name
co
is too short, but they accepted it finally.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a great idea, people who aren't familiar with the project we get confused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
co has 2k2 stars and there is no other project using same name in c++ universe. We are fine using co.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we need to be careful with that.
there are at very least:
not to count numerous generic abbreviation usages like Columbia, Colorado, Corsican, Commercia, etc.
so I agree with @uilianries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This is ok as long as we don't need to add this to many recipes in order to build M1 binaries.
Anyway, we should think about a solution from the CI side, because upgrading CMake system-wide is not a solution (we will use minimum version required here https://github.com/conan-io/tribe/blob/main/design/004-tools-cmake.md)