Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stb/20200203 #784

Merged
merged 5 commits into from
Feb 28, 2020
Merged

Add stb/20200203 #784

merged 5 commits into from
Feb 28, 2020

Conversation

Croydon
Copy link
Contributor

@Croydon Croydon commented Feb 4, 2020

Based on https://github.com/conan-community/conan-stb

Specify library name and version: stb/20200203

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

All green in build 1 (3135b34649db36b48ffb23030f2636bf3d2af190)! 😊

@Croydon Croydon requested review from danimtb and uilianries February 4, 2020 05:36
danimtb
danimtb previously approved these changes Feb 4, 2020
View reviewed changes
@conan-center-bot
Copy link
Collaborator

All green in build 2 (9ea8e60ec0496cad24d281d484c4c15babab6fd3)! 😊

SSE4
SSE4 suggested changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove dead code, otherwise looks good

@conan-center-bot
Copy link
Collaborator

All green in build 3 (1ff004276977306000dad988a617a4e14d58fd52)! 😊

@conan-center-bot
Copy link
Collaborator

All green in build 4 (2478723adc84a5e01aaea9bfb9838fbaf82b0316)! 😊

@madebr madebr mentioned this pull request Feb 10, 2020
Merged
4 tasks
@Croydon @madebr
stb: Read commit dynamically from conandata.yml
722a6e7 
Co-Authored-By: Anonymous Maarten <anonymous.maarten@gmail.com>
@conan-center-bot
Copy link
Collaborator

All green in build 5 (722a6e7a6545ee8f1e1e914ae2ff17c71bba9fb7)! 😊

@madebr madebr mentioned this pull request Feb 18, 2020
Merged
4 tasks
@gocarlos gocarlos mentioned this pull request Feb 24, 2020
Closed
@danimtb danimtb self-assigned this Feb 28, 2020
@danimtb danimtb merged commit 6105dfe into conan-io:master Feb 28, 2020
@CroydonBot CroydonBot deleted the stb branch February 28, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madebr madebr madebr left review comments

@danimtb danimtb danimtb approved these changes

@uilianries uilianries uilianries approved these changes

@SSE4 SSE4 SSE4 approved these changes

Assignees

@danimtb danimtb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Croydon @conan-center-bot @SSE4 @madebr @uilianries @danimtb