Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xorg: don't install xorg-dev #8388

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented Dec 10, 2021

Specify library name and version: xorg/system

xorg-dev installs xserver-xorg-dev, which is useless for conan packages, and brings unwanted stuff like libpciaccess, mesa-common-dev, libpixman, etc.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Dec 10, 2021

I detected other pull requests that are modifying xorg/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Dec 10, 2021
4 tasks
@conan-center-bot
Copy link
Collaborator

All green in build 2 (ec004ab798584633557d44c3794ac6ffddaaf13b):

  • xorg/system@:
    All packages built successfully! (All logs)

@ericLemanissier
Copy link
Contributor Author

here is the list of packages which are not installed any more:

libdmx-dev
libdmx1
libdrm-amdgpu1
libdrm-common
libdrm-dev
libdrm-intel1
libdrm-nouveau2
libdrm-radeon1
libdrm2
libedit2
libelf1
libfs-dev
libfs6
libgl-dev
libgl1
libgl1-mesa-dri
libglapi-mesa
libglvnd0
libglx-dev
libglx-mesa0
libglx0
libllvm12
libpciaccess-dev
libpciaccess0
libpixman-1-0
libpixman-1-dev
libsensors-config
libsensors5
libvulkan1
libxcb-dri2-0
libxcb-glx0
libxcb-present0
libxfont-dev
libxfont2
libxshmfence1
libxxf86dga-dev
libxxf86dga1
mesa-common-dev
x11proto-core-dev
x11proto-xf86dga-dev
xorg-dev
xserver-xorg-dev

It passed on all recent ubuntu and debian distros : https://github.com/bincrafters/system-packages-checks/actions/runs/1563769834

Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if packages still build successfully, I have no objections

@conan-center-bot conan-center-bot merged commit 6526967 into conan-io:master Dec 17, 2021
@ericLemanissier ericLemanissier deleted the patch-8 branch December 17, 2021 05:54
miklelappo pushed a commit to miklelappo/conan-center-index that referenced this pull request Feb 9, 2022
* xorg: don't install xorg-dev

* Update conanfile.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants