Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8848 - Add new recipe for whereami/20220112 #8850

Merged
merged 5 commits into from
Jan 25, 2022

Conversation

jmarrec
Copy link
Contributor

@jmarrec jmarrec commented Jan 12, 2022

cf https://github.com/gpakosz/whereami

I somewhat adapted https://github.com/bincrafters/conan-whereami. Revamped the example to use a C one (following https://github.com/gpakosz/whereami/blob/master/example/executable.c), conformed to conan-hooks, and added a cmake target.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

recipes/whereami/all/conanfile.py Outdated Show resolved Hide resolved
recipes/whereami/all/conanfile.py Outdated Show resolved Hide resolved
recipes/whereami/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@jmarrec
Copy link
Contributor Author

jmarrec commented Jan 17, 2022

@uilianries I am confused by the "unexpected error". Seems like 3 builds at the end are only reporting profile, not build nor test https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/8850/4-configs/windows-visual_studio/whereami/20220112//summary.json

@jgsogo
Copy link
Contributor

jgsogo commented Jan 21, 2022

@uilianries I am confused by the "unexpected error". Seems like 3 builds at the end are only reporting profile, not build nor test https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/8850/4-configs/windows-visual_studio/whereami/20220112//summary.json

@jmarrec, The unexpected error is just the final catch-em-all in a try/catch block, so looks like something happened while building one of those last Windows configurations. The logic to collect the log (successful and failed builds) is inside the try, when we capture this exception we just try to kill things in order, we send a message to our internal slack, and report some message to the user. This is why those logs are not reported.

@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Jan 24, 2022
SSE4
SSE4 previously approved these changes Jan 24, 2022
Copy link
Contributor

@SpaceIm SpaceIm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no official CMake config file. Just let conan generate default config file & target, otherwise it's just confusing and unecessary complexity.

recipes/whereami/all/conanfile.py Outdated Show resolved Hide resolved
recipes/whereami/all/conanfile.py Outdated Show resolved Hide resolved
recipes/whereami/all/conanfile.py Outdated Show resolved Hide resolved
recipes/whereami/all/conanfile.py Outdated Show resolved Hide resolved
@jmarrec
Copy link
Contributor Author

jmarrec commented Jan 25, 2022

Cleaned up per review comments and rebased onto master. Tested locally on Ubuntu 20.04 that it still works

SSE4
SSE4 previously approved these changes Jan 25, 2022
@conan-center-bot

This comment has been minimized.

@jmarrec
Copy link
Contributor Author

jmarrec commented Jan 25, 2022

we usually don't add conan topic these days, but that's not a big deal

I probably misread the intent here. Apparently the hook does want to see topics. I'll put them back, minus the "conan" one

@SSE4
Copy link
Contributor

SSE4 commented Jan 25, 2022

we usually don't add conan topic these days, but that's not a big deal

I probably misread the intent here. Apparently the hook does want to see topics. I'll put them back, minus the "conan" one

sorry, I wasn't clear enough. I mean topic named conan is not necessary, but other topics are okay. so it should be:

topics = "whereami", "introspection", "getmodulefilename",

@conan-center-bot
Copy link
Collaborator

All green in build 8 (49c97d526420a89d8a3929948f2fd15c1562ed9f):

  • whereami/20220112@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 8e75f72 into conan-io:master Jan 25, 2022
@jmarrec
Copy link
Contributor Author

jmarrec commented Jan 25, 2022

Thanks for the reviews and help!

@jmarrec jmarrec deleted the whereami_recipe branch January 25, 2022 10:09
@Croydon
Copy link
Contributor

Croydon commented Jan 25, 2022

Unless I'm missing something, the versioning is wrong. As there seems to be no upstream versioning, it should have been prefixed with cci.

https://github.com/conan-io/conan-center-index/blob/master/docs/faqs.md#what-version-should-packages-use-for-libraries-without-official-releases

@uilianries uilianries mentioned this pull request Jan 25, 2022
4 tasks
@SpaceIm
Copy link
Contributor

SpaceIm commented Jan 25, 2022

Good catch

@jmarrec
Copy link
Contributor Author

jmarrec commented Jan 25, 2022

Didn't know that, thanks for pointing to the documentation @Croydon, I'm making a mental note for the future.

Sahnvour pushed a commit to Sahnvour/conan-center-index that referenced this pull request Jan 30, 2022
* Fix conan-io#8848 - Add whereami/20220112

cf https://github.com/gpakosz/whereami

* address review comments by @uilianries

* Clean up recipe

per reviews from @SpaceIm and @toge

* Put back topics

* Please the hook KB-H062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] whereami/20220112
8 participants