-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #8848 - Add new recipe for whereami/20220112 #8850
Conversation
400dd20
to
e5ff1fd
Compare
This comment has been minimized.
This comment has been minimized.
8ce9a09
to
2b08544
Compare
This comment has been minimized.
This comment has been minimized.
@uilianries I am confused by the "unexpected error". Seems like 3 builds at the end are only reporting profile, not build nor test https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/8850/4-configs/windows-visual_studio/whereami/20220112//summary.json |
@jmarrec, The unexpected error is just the final |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no official CMake config file. Just let conan generate default config file & target, otherwise it's just confusing and unecessary complexity.
2b08544
to
d310931
Compare
Cleaned up per review comments and rebased onto master. Tested locally on Ubuntu 20.04 that it still works |
This comment has been minimized.
This comment has been minimized.
I probably misread the intent here. Apparently the hook does want to see topics. I'll put them back, minus the "conan" one |
sorry, I wasn't clear enough. I mean topic named
|
All green in build 8 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the reviews and help! |
Unless I'm missing something, the versioning is wrong. As there seems to be no upstream versioning, it should have been prefixed with |
Good catch |
Didn't know that, thanks for pointing to the documentation @Croydon, I'm making a mental note for the future. |
* Fix conan-io#8848 - Add whereami/20220112 cf https://github.com/gpakosz/whereami * address review comments by @uilianries * Clean up recipe per reviews from @SpaceIm and @toge * Put back topics * Please the hook KB-H062
cf https://github.com/gpakosz/whereami
I somewhat adapted https://github.com/bincrafters/conan-whereami. Revamped the example to use a C one (following https://github.com/gpakosz/whereami/blob/master/example/executable.c), conformed to conan-hooks, and added a cmake target.
conan-center hook activated.