add lzfse/1.0

[SpaceIm]

Specify library name and version: lzfse/1.0

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

#621

[conan-center-bot]

Some configurations of 'lzfse/1.0' failed in build 1 (275ea61c1a3c548640769072bd3c647ae2d8f16f):

• Linux x86_64, Release, gcc 4.9, libstdc++ . Options: lzfse:shared-True
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, gcc 4.9, libstdc++ . Options: lzfse:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Debug, gcc 4.9, libstdc++ . Options: lzfse:shared-True
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Debug, gcc 4.9, libstdc++ . Options: lzfse:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs

[conan-center-bot]

All green in build 2 (af958a18ff79ec10266482f6003b98385b8548a2)! 😊

• lzfse/1.0: Generated 82 packages. All logs here

[uilianries]

@SpaceIm please, consider SpaceIm#5

[SpaceIm]

@uilianries

• If I understand, it is preferred to also build exe if available, so that the package can also be used as a build requirement?
• except for POSITION_INDEPENDENT_CODE TRUE, modifications in patch file seems to be useless (LZFSE_BUNDLE_MODE is False). Therefore, is not a better solution to use replace_in_file, since patches can be painful to maintain across versions.

[uilianries]

If I understand, it is preferred to also build exe if available, so that the package can also be used as a build requirement?

Yes. As that package is more about the library and not the executable, it doesn't require an extra package only for the installer.

except for POSITION_INDEPENDENT_CODE TRUE, modifications in patch file seems to be useless (LZFSE_BUNDLE_MODE is False). Therefore, is not a better solution to use replace_in_file, since patches can be painful to maintain across versions.

No, because it forces BUILD_SHARED_LIBS.

[SpaceIm]

When LZFSE_BUNDLE_MODE is False, BUILD_SHARED_LIBS is an option, therefore it's not forced.

[uilianries]

Sorry, indeed it's an option. I need to update that patch.

[uilianries]

@SpaceIm , done, please take a look again on that PR

[SpaceIm]

@uilianries, last part of the patch file is also useless. You can keep the original replace_in_file I think, and remove references to patch file in conandata.yml and conanfile.py.

[uilianries]

hmm, that's true too. @SpaceIm please, ignore that patch and call cmake.install() instead.

[uilianries]

Thanks @SpaceIm !

[conan-center-bot]

All green in build 3 (edf9a9af864ecd5ba9e2f73b905c392cc7088426)! 😊

• lzfse/1.0: Generated 82 packages. All logs here