libtomcrypt: added v1.18.2

[jowr]

libtomcrypt/1.18.2

This is an established cryptographic library and I have several projects that use it. I am sure that others also find this package useful given the popularity this library. See https://github.com/libtom/libtomcrypt for details.

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

[CLAassistant]

All committers have signed the CLA.

[uilianries]

LGTM

[prince-chrismc]

It's really good! Just one nit picky thing to future proof

[jowr]

Thanks for reviewing!

[prince-chrismc]

Why does windows fail? 😖

https://github.com/conan-io/conan-center-index/pull/9066/files/e1070dab2d8d247aa8fd1689dc818ee383d57591..c76a50df9d9863e19d358fbf61b4931d4e3265c2 should have changes anything...

Looking at it seems like a one off random

https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/9066/6-configs/windows-visual_studio/libtomcrypt/1.18.2//summary.json

Maybe retrigger CI, close the pr wait 10s and then re-open it 🔁 if not I'll ask for help

[shiena]

I have found similar error issue. #9285
Does cmake_find_package seem relevant?

[prince-chrismc]

Sadly no, the test package does not use CMake, it seems there's more work required to get the windows shared exports to work correctly 😢 the lib is missing symbols

[shiena]

@jowr
Diff to build test_package with cmake instead of pkg-config. Does this seem to build?

diff --git a/recipes/libtomcrypt/all/test_package/CMakeLists.txt b/recipes/libtomcrypt/all/test_package/CMakeLists.txt
index c13db6494..6c6db0de2 100644
--- a/recipes/libtomcrypt/all/test_package/CMakeLists.txt
+++ b/recipes/libtomcrypt/all/test_package/CMakeLists.txt
@@ -2,11 +2,10 @@ cmake_minimum_required(VERSION 3.1)
 project(test_package C)
 
 include("${CMAKE_BINARY_DIR}/conanbuildinfo.cmake")
-conan_basic_setup(TARGETS)
+conan_basic_setup()
 
-include(FindPkgConfig)
-pkg_check_modules(LibTomCrypt REQUIRED IMPORTED_TARGET libtomcrypt)
+find_package(LibTomCrypt REQUIRED)
 
 add_executable(${PROJECT_NAME} test_package.c)
-target_link_libraries(${PROJECT_NAME} PRIVATE PkgConfig::LibTomCrypt)
+target_link_libraries(${PROJECT_NAME} PRIVATE ${CONAN_LIBS})
 target_compile_definitions(${PROJECT_NAME} PRIVATE LTC_NO_PROTOTYPES)
diff --git a/recipes/libtomcrypt/all/test_package/conanfile.py b/recipes/libtomcrypt/all/test_package/conanfile.py
index 9e09e219f..3da371b66 100644
--- a/recipes/libtomcrypt/all/test_package/conanfile.py
+++ b/recipes/libtomcrypt/all/test_package/conanfile.py
@@ -4,10 +4,7 @@ import os
 
 class TestPackageConan(ConanFile):
     settings = "os", "compiler", "build_type", "arch"
-    generators = "cmake", "pkg_config"
-
-    def build_requirements(self):
-        self.build_requires("pkgconf/1.7.4")
+    generators = "cmake", "cmake_find_package"
 
     def build(self):
         cmake = CMake(self)

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[conan-center-bot]

Failure in build 10 (c76a50df9d9863e19d358fbf61b4931d4e3265c2):

• libtomcrypt/1.18.2@:
  CI failed to create some packages (All logs)

  Logs for packageID 78d2b195d74b061a2827b6f2fb461c55864b1c2a:

  [settings]
  arch=x86_64
  build_type=Release
  compiler=Visual Studio
  compiler.runtime=MD
  compiler.version=15
  os=Windows
  [options]
  libtomcrypt:shared=False
  

  [...]
  -- Detecting C compiler ABI info - done
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- Conan: called by CMake conan helper
  -- Conan: Adjusting output directories
  -- Conan: Using cmake targets configuration
  -- Library tomcrypt found C:/J/w/prod/BuildSingleReference/.conan/data/libtomcrypt/1.18.2/_/_/package/78d2b195d74b061a2827b6f2fb461c55864b1c2a/lib/tomcrypt.lib
  -- Library tommath found C:/J/w/prod/BuildSingleReference/.conan/data/libtommath/1.2.0/_/_/package/6cc50b139b9c3d27b3e9042d5f5372d327b3a9f7/lib/tommath.lib
  -- Conan: Adjusting default RPATHs Conan policies
  -- Conan: Adjusting language standard
  -- This project seems to be plain C, using 'MSVC' compiler
  -- Found PkgConfig: C:/J/w/prod/BuildSingleReference/.conan/data/pkgconf/1.7.4/_/_/package/0a420ff5c47119e668867cdb51baff0eca1fdb68/bin/pkgconf.exe (found version "1.7.4") 
  -- Checking for module 'libtomcrypt'
  --   Found libtomcrypt, version 1.18.2
  -- Configuring done
  -- Generating done
  -- Build files have been written to: C:/J/w/prod/BuildSingleReference/conan-center-index/recipes/libtomcrypt/all/test_package/build/7fe9ef1ba2f76fec0e0bf625fe2066f44395e393
  
  ----Running------
  > cmake --build C:\J\w\prod\BuildSingleReference\conan-center-index\recipes\libtomcrypt\all\test_package\build\7fe9ef1ba2f76fec0e0bf625fe2066f44395e393 --config Release -- /m:8 /verbosity:minimal
  -----------------
  Microsoft (R) Build Engine version 15.9.21+g9802d43bc3 for .NET Framework
  Copyright (C) Microsoft Corporation. All rights reserved.
  
    Checking Build System
    Building Custom Rule C:/J/w/prod/BuildSingleReference/conan-center-index/recipes/libtomcrypt/all/test_package/CMakeLists.txt
    test_package.c
  test_package.obj : error LNK2019: unresolved external symbol register_cipher referenced in function main [C:\J\w\prod\BuildSingleReference\conan-center-index\recipes\libtomcrypt\all\test_package\build\7fe9ef1ba2f76fec0e0bf625fe2066f44395e393\test_package.vcxproj]
  test_package.obj : error LNK2019: unresolved external symbol register_hash referenced in function main [C:\J\w\prod\BuildSingleReference\conan-center-index\recipes\libtomcrypt\all\test_package\build\7fe9ef1ba2f76fec0e0bf625fe2066f44395e393\test_package.vcxproj]
  test_package.obj : error LNK2019: unresolved external symbol register_prng referenced in function main [C:\J\w\prod\BuildSingleReference\conan-center-index\recipes\libtomcrypt\all\test_package\build\7fe9ef1ba2f76fec0e0bf625fe2066f44395e393\test_package.vcxproj]
  test_package.obj : error LNK2019: unresolved external symbol rijndael_enc_desc referenced in function main [C:\J\w\prod\BuildSingleReference\conan-center-index\recipes\libtomcrypt\all\test_package\build\7fe9ef1ba2f76fec0e0bf625fe2066f44395e393\test_package.vcxproj]
  test_package.obj : error LNK2019: unresolved external symbol sha256_desc referenced in function main [C:\J\w\prod\BuildSingleReference\conan-center-index\recipes\libtomcrypt\all\test_package\build\7fe9ef1ba2f76fec0e0bf625fe2066f44395e393\test_package.vcxproj]
  test_package.obj : error LNK2019: unresolved external symbol yarrow_desc referenced in function main [C:\J\w\prod\BuildSingleReference\conan-center-index\recipes\libtomcrypt\all\test_package\build\7fe9ef1ba2f76fec0e0bf625fe2066f44395e393\test_package.vcxproj]
  C:\J\w\prod\BuildSingleReference\conan-center-index\recipes\libtomcrypt\all\test_package\build\7fe9ef1ba2f76fec0e0bf625fe2066f44395e393\bin\test_package.exe : fatal error LNK1120: 6 unresolved externals [C:\J\w\prod\BuildSingleReference\conan-center-index\recipes\libtomcrypt\all\test_package\build\7fe9ef1ba2f76fec0e0bf625fe2066f44395e393\test_package.vcxproj]
  CMake Warning:
    Manually-specified variables were not used by the project:
  
      CMAKE_EXPORT_NO_PACKAGE_REGISTRY
      CMAKE_INSTALL_BINDIR
      CMAKE_INSTALL_DATAROOTDIR
      CMAKE_INSTALL_INCLUDEDIR
      CMAKE_INSTALL_LIBDIR
      CMAKE_INSTALL_LIBEXECDIR
      CMAKE_INSTALL_OLDINCLUDEDIR
      CMAKE_INSTALL_SBINDIR
  
  
  ERROR: libtomcrypt/1.18.2 (test package): Error in build() method, line 15
  	cmake.build()
  	ConanException: Error 1 while executing cmake --build C:\J\w\prod\BuildSingleReference\conan-center-index\recipes\libtomcrypt\all\test_package\build\7fe9ef1ba2f76fec0e0bf625fe2066f44395e393 --config Release -- /m:8 /verbosity:minimal
  

---

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.