Add ExprTk package #9355
Add ExprTk package #9355
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@prince-chrismc / @lasote : Would either of you know how I should go about assigning reviewers to this PR? or does it happen automatically? |
yes, bot automatically assigns reviewers from time to time |
| cmake.build() | ||
|
|
||
| def test(self): | ||
| if not tools.cross_building(self.settings): |
There was a problem hiding this comment.
| if not tools.cross_building(self.settings): | |
| if not tools.cross_building(self): |
self.settings is not invalid parameter for cross_building() now.
Please use self.
There was a problem hiding this comment.
Made the suggested change.
712 if not tools.cross_building(self):
498 if not tools.cross_building(self.settings):
|
All green in build 4 (
|
We have some docs with more details https://github.com/conan-io/conan-center-index/blob/master/docs/review_process.md#getting-your-pull-request-reviewed. Let me know if it's hard to find, we can try finding a better place of better key words to search! |
No description provided.