Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass CONAN_USERNAME envvar to docker (#479) #482

Closed
wants to merge 1 commit into from
Closed

pass CONAN_USERNAME envvar to docker (#479) #482

wants to merge 1 commit into from

Conversation

Artalus
Copy link
Contributor

@Artalus Artalus commented Mar 10, 2020

fixes #479

Changelog: Fix: Fix empty username on Docker

Due to _noneize() being used during construction of ConanFileReference, the user and channel parts of reference object are replaced from '_' to None.
Thus, when user provides CONAN_USERNAME=_, CONAN_CHANNEL=_ for CPT to be forwarded to docker run, the username var was reset to None, causing Conan running inside docker to think that the user provided only one envvar.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.

@kasunch
Copy link
Contributor

kasunch commented Nov 13, 2020

I have been using this fix in my fork for sometime with the hope that this will be merged eventually.
Is there any reason why this hasn't been merged yet?

@uilianries
Copy link
Member

It sounds good for packages which doesn't contain user/channel. I gonna check a test for it first. Without a test we can't accept it.

@uilianries uilianries added this to the 0.35.1 milestone Mar 15, 2021
@uilianries
Copy link
Member

I've opened PR #522 over this PR, it contains an integration test which is possible to validate your hotfix. That PR respects your commit (author) and will close this one as soon as it gets merged.

@uilianries uilianries closed this Mar 16, 2021
@uilianries uilianries removed this from the 0.35.1 milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional username/channel treated differently on different OSes
3 participants