pass CONAN_USERNAME envvar to docker (#479) #482
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #479
Changelog: Fix: Fix empty username on Docker
Due to
_noneize()
being used during construction ofConanFileReference
, theuser
andchannel
parts of reference object are replaced from'_'
toNone
.Thus, when user provides
CONAN_USERNAME=_, CONAN_CHANNEL=_
for CPT to be forwarded todocker run
, the username var was reset toNone
, causing Conan running inside docker to think that the user provided only one envvar.