-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look for matching Conan profile in a config file for the running VS configuration #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgsogo
commented
Jun 26, 2019
jgsogo
commented
Jun 26, 2019
SSE4
reviewed
Jun 26, 2019
Please, @SSE4 , review again and test the functionality. I think it could be almost ready. 😸 |
Merged
I think it deserves an example project with:
|
Very basic example added, check it works as expected (using the |
works for me, please un-draft the PR |
SSE4
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension looks into a file
conan.config.json
for a Conan profile name associated with the Visual Studio configuration. This file is searched first in the same directory as the VS Project, and then in any parent directory.The format for this file (it should be extensible in the future):
Under the
"configurations"
key there is a dictionary with the correspondence between the VS configuration (key, on the left) and a Conan profile (value, on the right). To take into account:|
character the name of theConfiguration
and thePlatform
.--profile
argument in theconan install
command, and rules related to profile lookup applies.closes #88
related to #5 (first iteration)