Remove 'conan-vs-settings.json' feature. #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSE4
reviewed
Jun 28, 2019
|
@jgsogo please undraft so we can merge |
|
No, we are removing a feature, although it is not documented it can break someone. We need more feedback about it. Maybe we need to provide a replacement before removing it. |
|
okay, may you split PR then? because it appears like you're removing more than just |
jgsogo
force-pushed
the
refact/remove-settings-json
branch
2 times, most recently
from
2a2ce3b to
46d8fe6
Compare
SSE4
force-pushed
the
refact/remove-settings-json
branch
from
46d8fe6 to
8373b49
Compare
|
@solvingj could you provide some feedback? |
SSE4
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conan-vs-settingsis not documented and we are currently moving towards aconan.config.json, better to start from scratch with this new approach.related #113
related #5