Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate path to Conan executable #136

Merged
merged 11 commits into from
Jul 16, 2019
Merged

Validate path to Conan executable #136

merged 11 commits into from
Jul 16, 2019

Conversation

SSE4
Copy link

@SSE4 SSE4 commented Jul 8, 2019

closes #117

SSE4 added 2 commits July 8, 2019 04:35
@SSE4
- validate conan executable
5424126 
Signed-off-by: SSE4 <tomskside@gmail.com>
@SSE4
- handle Win32Exception during the conan invocation
0518ae5 
Signed-off-by: SSE4 <tomskside@gmail.com>
@SSE4 SSE4 added this to the 1.2.0 milestone Jul 8, 2019
@SSE4 SSE4 requested a review from jgsogo July 8, 2019 14:25
@jgsogo
Copy link

jgsogo commented Jul 16, 2019

Rebase with dev and solve conflicts, please

@jgsogo jgsogo changed the title validate conan executable Validate path to Conan executable Jul 16, 2019
@jgsogo jgsogo assigned SSE4 and unassigned jgsogo Jul 16, 2019
@SSE4
Copy link
Author

SSE4 commented Jul 16, 2019

@jgsogo rebased

jgsogo
jgsogo suggested changes Jul 16, 2019
View reviewed changes
Copy link

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • If I set an invalid path and click Cancel button in the Options window, I still get the messagebox although the changes should be discarded.

Conan.VisualStudio.Core/ConanPathHelper.cs Show resolved Hide resolved
Conan.VisualStudio/ConanOptionsPage.cs Outdated Show resolved Hide resolved
@SSE4
Copy link
Author

SSE4 commented Jul 16, 2019

that's totally weird, it means changes applied even if we hit cancel? I believe setter should be never called in case of cancelation.

jgsogo
jgsogo approved these changes Jul 16, 2019
View reviewed changes
Copy link

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got it, @SSE4 👌

@SSE4 SSE4 merged commit 523f5a2 into conan-io:dev Jul 16, 2019
This was referenced Jul 19, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsogo jgsogo jgsogo approved these changes

Assignees

@SSE4 SSE4

Labels
enhancement
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Validate Conan executable
2 participants
@SSE4 @jgsogo