Show Conan version in every log before running the install #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSE4
reviewed
Aug 2, 2019
|
|
||
| namespace Conan.VisualStudio | ||
| { | ||
| public static class Utils |
There was a problem hiding this comment.
may we use something more specific instead of just utils?
There was a problem hiding this comment.
Suggest a name, my plan is to gather common utilities like this run, maybe som print-to-log-and-output,... in a single place to make them more reusable.
SSE4
reviewed
Aug 2, 2019
SSE4
reviewed
Aug 2, 2019
SSE4
reviewed
Aug 2, 2019
SSE4
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conan version is very useful information for any error report.
This PR also creates a
Utils.RunProcessAsyncfunction to run commands, it can be reused from other parts of the project.closes #149