Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert .NET Standard Class libraries to .NET Framework Class libraries #89

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

SSE4
Copy link

@SSE4 SSE4 commented Jun 13, 2019

closes #87
we have Conan.VisualStudio.Core and VisualStudio.OpenFolder projects created as .NET Standard Class Libraries. as result they depend on .NET Standard 2.0.
on other note, Conan.VisualStudio itself targets .NET Framework v4.6.1.
I guess it's better to keep them consistent, and just use .NET Framework v4.6.1 everywhere.
therefore, I've re-created two mentioned above projects as .NET Framework Class libraries.

…ries

Signed-off-by: SSE4 <tomskside@gmail.com>
@SSE4 SSE4 requested a review from jgsogo June 13, 2019 12:52
Copy link

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice move!

@jgsogo jgsogo added this to the 1.1 milestone Jun 13, 2019
@jgsogo jgsogo merged commit 0dcb55e into dev Jun 13, 2019
@jgsogo jgsogo deleted the convert_to_dotnetframework branch June 13, 2019 15:24
@Gernatch Gernatch mentioned this pull request Jun 17, 2019
@jgsogo jgsogo changed the title convert .NET Standard Class libraries to .NET Framework Class libraries Convert .NET Standard Class libraries to .NET Framework Class libraries Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vs2017] Error loading in VS 2017
2 participants