Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish to OpenVSIX gallery #92

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Publish to OpenVSIX gallery #92

merged 2 commits into from
Jun 17, 2019

Conversation

SSE4
Copy link

@SSE4 SSE4 commented Jun 13, 2019

closes #65

@SSE4 SSE4 requested a review from jgsogo June 13, 2019 20:24
jgsogo
jgsogo suggested changes Jun 17, 2019
View reviewed changes
Copy link

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should run only for master branch, the same we do to upload to the Microsoft Marketplace.

jgsogo
jgsogo suggested changes Jun 17, 2019
View reviewed changes
Copy link

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should run only for master branch, the same we do to upload to the Microsoft Marketplace.

@jgsogo jgsogo added this to the 1.1 milestone Jun 17, 2019
@jgsogo
Copy link

jgsogo commented Jun 17, 2019

What about Github, chocolatey or nuget? I think it is ok to have the extension only in the Gallery and in the marketplace. What do you think? Shall we close the issue and wait for someone else to open it again in the future?

@jgsogo jgsogo mentioned this pull request Jun 17, 2019
Closed
@SSE4
Copy link
Author

SSE4 commented Jun 17, 2019

let's break down, each one deserves its own issue/pull request.

  • GitHub - I think important, as Microsoft allows only to use later, and you can't easily rollback
  • Chocolatey - might be useful for automated installation (Enterprise set up, or things like puppet to bootstrap the env)
  • NuGet - no idea, need some feedback

jgsogo
jgsogo approved these changes Jun 17, 2019
View reviewed changes
Copy link

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 VSIX Gallery, here we go!

@jgsogo jgsogo merged commit cece7d5 into dev Jun 17, 2019
@jgsogo jgsogo deleted the openvsix_publish branch June 17, 2019 10:25
@jgsogo jgsogo changed the title publish to OpenVSIX gallery Publish to OpenVSIX gallery Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsogo jgsogo jgsogo approved these changes

Assignees

@jgsogo jgsogo

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Define policy to publish in Github and Open VSIX gallery
2 participants
@SSE4 @jgsogo