[bugfix] Version int comparison (#12934)

fixed error comparing between integers
conan-io · Jan 20, 2023 · 6e585bd · 6e585bd
1 parent b7c012d
commit 6e585bd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/conans/model/version.py b/conans/model/version.py
@@ -159,7 +159,7 @@ def __repr__(self):
     def __eq__(self, other):
         if other is None:
             return False
-        if isinstance(other, str):
+        if not isinstance(other, Version):
             other = Version(other)
 
         return (self._nonzero_items, self._pre, self._build) ==\

diff --git a/conans/test/unittests/model/version/test_version_comparison.py b/conans/test/unittests/model/version/test_version_comparison.py
@@ -53,6 +53,15 @@ def test_comparison(v1, v2):
     assert v2 >= v1
 
 
+def test_comparison_with_integer():
+    v1 = Version("13.0")
+    # Issue: https://github.com/conan-io/conan/issues/12907
+    assert v1 > 5
+    assert not v1 > 20
+    assert v1 < 20
+    assert v1 == 13
+
+
 e = [("1", "1.0"),
      ("1", "1.0.0"),
      ("1.0", "1.0.0"),