Enable authentication against a disabled remote (#12913)

* Make deactivate_conanx a function instead of an extra file

* Make remote authenticate stop checking for remote.disabled

* Revert change from different PR

* Add even more missing parts

* Adds test and makes api nicer

conan/cli/commands/remote.py

@@ -177,7 +177,7 @@ def remote_login(conan_api, parser, subparser, *args):
                                 'requested interactively (not exposed)')
 
     args = parser.parse_args(*args)
-    remotes = conan_api.remotes.list(pattern=args.remote)
+    remotes = conan_api.remotes.list(pattern=args.remote, only_enabled=False)
     if not remotes:
         raise ConanException("There are no remotes matching the '{}' pattern".format(args.remote))
 

conans/client/remote_manager.py

@@ -160,7 +160,7 @@ def remove_all_packages(self, ref, remote):
         return self._call_remote(remote, "remove_all_packages", ref)
 
     def authenticate(self, remote, name, password):
-        return self._call_remote(remote, 'authenticate', name, password)
+        return self._call_remote(remote, 'authenticate', name, password, enforce_disabled=False)
 
     def get_recipe_revisions_references(self, ref, remote):
         assert ref.revision is None, "get_recipe_revisions_references of a reference with revision"
@@ -199,7 +199,8 @@ def get_package_revision_reference(self, pref, remote) -> bool:
 
     def _call_remote(self, remote, method, *args, **kwargs):
         assert (isinstance(remote, Remote))
-        if remote.disabled:
+        enforce_disabled = kwargs.pop("enforce_disabled", True)
+        if remote.disabled and enforce_disabled:
             raise ConanException("Remote '%s' is disabled" % remote.name)
         try:
             return self._auth_manager.call_rest_api_method(remote, method, *args, **kwargs)

conans/test/integration/remote/auth_test.py

@@ -129,6 +129,15 @@ def test_no_client_username_checks(self):
         self.assertTrue(os.path.exists(self.test_server.server_store.export(ref)))
         self.assertIn('Please enter a password for "some_random.special!characters"', client.out)
 
+    def test_authorize_disabled_remote(self):
+        tc = TestClient(servers=self.servers)
+        # Sanity check, this should not fail
+        tc.run("remote login default pepe -p pepepass")
+        tc.run("remote logout default")
+        # This used to fail when the authentication was not possible for disabled remotes
+        tc.run("remote disable default")
+        tc.run("remote login default pepe -p pepepass")
+        self.assertIn("Changed user of remote 'default' from 'None' (anonymous) to 'pepe' (authenticated)", tc.out)
 
 class AuthenticationTest(unittest.TestCase):