Make skipped binaries prettier (#13919)

* Make skipped binaries prettier * Remove [] * Fix sneaky test I did not find previously
conan-io · May 22, 2023 · c00cd10 · c00cd10
1 parent 10f1786
commit c00cd10
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/conan/cli/printers/graph.py b/conan/cli/printers/graph.py
@@ -123,4 +123,4 @@ def _format_requires(title, reqs_to_print):
 
     if skipped_requires and not output.level_allowed(LEVEL_VERBOSE):
         output.info("Skipped binaries", Color.BRIGHT_YELLOW)
-        output.info(f"{tab}{skipped_requires}", Color.BRIGHT_CYAN)
+        output.info(f"{tab}{', '.join(skipped_requires)}", Color.BRIGHT_CYAN)
diff --git a/conans/test/integration/graph/test_skip_binaries.py b/conans/test/integration/graph/test_skip_binaries.py
@@ -82,7 +82,7 @@ def test_test_requires():
     client.save({"conanfile.py": GenConanfile().with_requires("pkg/1.0")})
     # Checking list of skipped binaries
     client.run("create . --name=app --version=1.0")
-    assert re.search(r"Skipped binaries(\s*)\['gtest/1.0'\]", client.out)
+    assert re.search(r"Skipped binaries(\s*)gtest/1.0", client.out)
     # Showing the complete information about the skipped binary
     client.run("create . --name=app --version=1.0 -v")
     client.assert_listed_binary({"gtest/1.0": (package_id, "Skip")}, test=True)

diff --git a/conans/test/integration/toolchains/apple/test_xcodedeps.py b/conans/test/integration/toolchains/apple/test_xcodedeps.py
@@ -475,6 +475,6 @@ def test_skipped_not_included():
     client.run("create dep --name=dep --version=0.1")
     client.run("create pkg --name=pkg --version=0.1")
     client.run("install consumer -g XcodeDeps -s arch=x86_64 -s build_type=Release")
-    assert re.search(r"Skipped binaries\n\s+(\[.*?\])", client.out, re.DOTALL)
+    assert re.search(r"Skipped binaries\n\s+(.*?)", client.out, re.DOTALL)
     dep_xconfig = client.load("consumer/conan_pkg_pkg.xcconfig")
     assert "conan_dep.xcconfig" not in dep_xconfig