Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of the authorization process #11776

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Allow customization of the authorization process #11776

merged 2 commits into from
Aug 24, 2022

Conversation

fpoirotte
Copy link
Contributor

@fpoirotte fpoirotte commented Aug 4, 2022

Changelog: Feature: Allow the authorization process in conan_server to be customized, just like authentication.
Docs: conan-io/docs#2684

Closes: #5758

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

The methods are already in use by the service.
@CLAassistant
Copy link

CLAassistant commented Aug 4, 2022

CLA assistant check
All committers have signed the CLA.

@franramirez688 franramirez688 added this to the 1.52 milestone Aug 9, 2022
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were thinking of requesting to add some tests, copying whatever the custom_authentication had. It seems that such tests don't even exist, so I am fine merging this as-is, no need to add tests, I guess that you have already tested this manually, haven't you?

Thanks for contributing to Conan.

@fpoirotte
Copy link
Contributor Author

Hi,

I did a few manual tests yesterday using the example plugin I posted in the docs' PR.
My tests worked as I intended and I did not notice any adverse effect.

@czoido czoido merged commit b3b2c87 into conan-io:develop Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Authorizer plugin in conan_server
6 participants