When the layout, use different folder for the 'conan infos' files #11820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasote
requested review from
jcar87 and
memsharded
and removed request for
jcar87 and
memsharded
lasote
changed the title
memsharded
reviewed
Aug 10, 2022
lasote
commented
Aug 11, 2022
| @@ -93,7 +93,7 @@ def test_autotools_relocatable_libs_darwin(): | |||
| shutil.move(os.path.join(package_folder, "lib"), os.path.join(client.current_folder, "tempfolder")) | |||
| # will fail because rpath does not exist | |||
| client.run_command("test_package/build-release/main", assert_error=True) | |||
| assert "Library not loaded: @rpath/libhello.0.dylib" in client.out | |||
| assert "Library not loaded: @rpath/libhello.0.dylib" in str(client.out).replace("'", "") | |||
There was a problem hiding this comment.
This is not related to this PR but fails with my apple-clang that output with quotes the rpath
lasote
changed the title
lasote
changed the title
memsharded
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: When the
layout()is declared in the recipe, the files such asconainfo.txt,conanbuildinfo.txtwere written in thetest_packagefolder, now there are written in thegenerators_folder.Docs: omit
Close #11779