tools.scm.Version in develop as is in develop2 #11823
Conversation
|
|
||
|
|
||
| @total_ordering | ||
| class Version: |
There was a problem hiding this comment.
Could you please add as_list, so it could be minimal compatible with what we have in Conan Center Index now.
There was a problem hiding this comment.
I wouldn't like that, I think that as_list is an ugly interface that if we do that it will "infect" Conan 2.0.
If necessary, please let us know the use cases of such method, and we can think about what is the right interface for it.
There was a problem hiding this comment.
I still prefer the legacy, as described in this PR. The only thing is re-editing recipes again in CCI. Also, we will need to create some if conan_version else because the different behavior from 1.49 (i guess) til 1.52
There was a problem hiding this comment.
I haven't found occurrences of as_list in conan-center-index (only one method in openssl recipe), am I missing something?
There was a problem hiding this comment.
Boost recipe: https://github.com/conan-io/conan-center-index/blob/master/recipes/boost/all/conanfile.py#L1461
If you are running GH search, forget, it's useless most of time.
There was a problem hiding this comment.
Furthermore, as_list is not a documented/public method at all, shouldn't be used in any of the Version implementations? While major and minor are. Not sure why they used that in the boost recipe.
There was a problem hiding this comment.
The problem was, Boost recipe need to compare some major and minor versions, but the new scm.Version does not support semver, so it return "1.2" for Version.minor(fill=False). Of course, the previous behavior, with semver, was much better. I gonna revert those changes and keep aligned with this new PR. Thanks.
There was a problem hiding this comment.
Not sure what you mean. This new Version in this PR supports semver like comparison between versions, no problem with that. How is that related to the as_list usage, which is done to just extract the major, minor and patch to compose some strings (suffixes) in the boost recipe?
There was a problem hiding this comment.
- The new Version changed major, minor and patch from property to method
- When you call
conan.tools.scm.Version('1.2.3').minor()it returns1.2.Z - When you call
conan.tools.scm.Version('1.2.3').minor(fill=False)it returns1.2 - But still, I only want the minor, the
2. - As alternative, I can consume from
conan.tools.scm.Version('1.2.3')[1]
Anyway, this new PR fixes the case, so we can use Version.major as a property again.
There was a problem hiding this comment.
When I said The new Version, I meant which is production right now and running on CCI, not this PR. This PR is correct, it follows the previous and expected behavior.
* conan v2 support * fix injection of bzip2 major version * use conan.tools.scm.Version again * no conan.tools.scm.Version to get major bzip2 version wait conan-io/conan#11823
Changelog: Bugfix: The
tool.scm.Versionmodel has been ported from 2.X to keep the same behavior in Conan 1.X.Docs: omit
Close #11821