Macro conan_package_library_targets reverted to single config
#11859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:lasote/conan into bugfix/cmakedeps_linked_libs_multiconfig
lasote
commented
Aug 12, 2022
| set(_out_libraries_target "") | ||
| set(_CONAN_ACTUAL_TARGETS "") |
There was a problem hiding this comment.
it was not needed, not related with the bug
lasote
commented
Aug 12, 2022
| foreach(_CONAN_ACTUAL_TARGET ${_CONAN_ACTUAL_TARGETS}) | ||
| get_target_property(linked_libs ${_CONAN_ACTUAL_TARGET} INTERFACE_LINK_LIBRARIES) | ||
| message(VERBOSE "Target Properties: ${_CONAN_ACTUAL_TARGET} INTERFACE_LINK_LIBRARIES ='${linked_libs}'") | ||
| foreach(_T ${_out_libraries_target}) |
There was a problem hiding this comment.
pure refactor to not use _CONAN_ACTUAL_TARGETS but _out_libraries_target
lasote
commented
Aug 12, 2022
| @@ -96,7 +96,7 @@ def template(self): | |||
| set_property(TARGET {{root_target_name}} | |||
| PROPERTY INTERFACE_LINK_LIBRARIES | |||
| $<$<CONFIG:{{configuration}}>:{{ '${'+pkg_name+'_OBJECTS'+config_suffix+'}' }}> | |||
| ${{'{'}}{{pkg_name}}_LIBRARIES_TARGETS} | |||
| $<$<CONFIG:{{configuration}}>:${{'{'}}{{pkg_name}}_LIBRARIES_TARGETS}> | |||
There was a problem hiding this comment.
So now we have to "protect" these library targets with the configuration
There was a problem hiding this comment.
Nice, this is exactly what I meant! Doing this by locally modifying generated cmake files is exactly how I worked around the issue ^^
memsharded
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: The CMakeDeps generator was not managing correctly the IMPORTED LOCATION of the libraries for different
build_type.Docs: omit
Close #11852
After investigating (thanks @jcar87) looks like the
IMPORTED_LOCATION_<build_type>doesn't make the targets of the library files multi-config, CMake only uses it as a priority based on other things like the config mappings. More (cryptic) info can be found here: https://gitlab.kitware.com/cmake/cmake/-/issues/16280So I decided to revert that part of the macro keeping the improvements introduced in the last release, that so far have worked ok.