Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export_conandata_patches utility #11911

Merged
merged 9 commits into from
Aug 24, 2022

Conversation

MartinDelille
Copy link
Contributor

@MartinDelille MartinDelille commented Aug 18, 2022

Changelog: Feature: Add export_conandata_patches tool.
Docs: conan-io/docs#2720

Closes: #11770
Closes: #11923

This issue has no test because I didn't managed to make it work but you can see this as a quick proposal before going further in the implementation.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@MartinDelille
Copy link
Contributor Author

@jgsogo I'll be happy to have your feedback on this feature that would replace this two lines by a simpler export_conandata_patches(self). Feel free to ping anyone who would be interested in this.

@jgsogo
Copy link
Contributor

jgsogo commented Aug 18, 2022

I suggested it too on my side... just to discover that @SpaceIm already suggested some days ago. IIRC it is assigned to 1.53

@jgsogo
Copy link
Contributor

jgsogo commented Aug 18, 2022

Anyway, I don't know if there's already a PR for it. When I'm back on my computer I'll have a look to the implementation

@SpaceIm
Copy link
Contributor

SpaceIm commented Aug 18, 2022

related issue: #11770

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need some integration tests

conan/tools/files/patches.py Outdated Show resolved Hide resolved
@MartinDelille MartinDelille force-pushed the export_conandata_patches branch from a75502b to cc07511 Compare August 19, 2022 14:01
@memsharded memsharded added this to the 1.52 milestone Aug 22, 2022
@memsharded memsharded marked this pull request as ready for review August 23, 2022 09:29
@memsharded
Copy link
Member

We would like this to be in 1.52 soon, so I have contributed a review, including completing the test and more error checking.

@memsharded memsharded assigned czoido and jcar87 and unassigned czoido Aug 23, 2022
@MartinDelille
Copy link
Contributor Author

Thanks!

Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@memsharded memsharded merged commit d3a6b69 into conan-io:develop Aug 24, 2022
@MartinDelille MartinDelille deleted the export_conandata_patches branch August 24, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants