-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add export_conandata_patches utility #11911
Add export_conandata_patches utility #11911
Conversation
@jgsogo I'll be happy to have your feedback on this feature that would replace this two lines by a simpler |
I suggested it too on my side... just to discover that @SpaceIm already suggested some days ago. IIRC it is assigned to 1.53 |
Anyway, I don't know if there's already a PR for it. When I'm back on my computer I'll have a look to the implementation |
related issue: #11770 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would need some integration tests
a75502b
to
cc07511
Compare
We would like this to be in 1.52 soon, so I have contributed a review, including completing the test and more error checking. |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changelog: Feature: Add
export_conandata_patches
tool.Docs: conan-io/docs#2720
Closes: #11770
Closes: #11923
This issue has no test because I didn't managed to make it work but you can see this as a quick proposal before going further in the implementation.
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.