Added endeavouros to the distro list in with_pacman in oss.py #11970

[cchulo]

Changelog: Bugfix: Add "endeavouros" to the list of distros with pacman.
Docs: Omit

Close #11970

• Refer to the issue that supports this Pull Request.
• If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
• I've read the Contributing guide.
• I've followed the PEP8 style guides for Python code.
• I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

^{Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.}

^{Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.}

[CLAassistant]

All committers have signed the CLA.

[memsharded]

Thanks for contributing

The integration that you are modifying is legacy, and shouldn't be used anymore.
The recommended one is in from conan.tools.system ...

Please have a look to https://docs.conan.io/en/latest/reference/conanfile/tools.html, and the place to do the modifications is in https://github.com/conan-io/conan/blob/develop/conan/tools/system/package_manager.py

[cchulo]

@memsharded done

[memsharded]

Have you tried this manually and it is working?
I thought it was ok, but I did a routine check on https://github.com/python-distro/distro/blob/master/src/distro/distro.py, and I don't think that distro.id() will be returning the endeavouros string. Am I missing something? Is distro capable of returning this even if not documented explicitly in the project?

[cchulo]

well this is why I had the previous change, I traced the code back to oss.py, though you said it was legacy, that's what led me to that file in the first place

[cchulo]

Actually I should be more specific, the initial commit to oss.py was traced back from OpenGL's recipe, tools which is imported from conans and then just reading that code led me to oss.py, I decided not to change that file at your advise that it is legacy and instead implemented the change at the other location you suggested, not exactly sure how to test this change to ensure that it is working. Still with your earlier advise to setup [conf] flags in my profile I was able to work around this anyway.

Give me a couple of more days to test this. If you have any ideas as to how to proceed please let me know.

[memsharded]

No, the code is ok, the change you did put the fix in the right place. I think the problem would be the same in the other legacy place as well.

The underlying issue is that Conan uses the return of distro.id() to feed it into those dictionaries. But it seems that distro.id() doesn't return endeavouros string, at least my inspection of the distro code. The way to check it would be just import distro + distro.id() in your python in your system.

[cchulo]

No, the code is ok, the change you did put the fix in the right place. I think the problem would be the same in the other legacy place as well.

The underlying issue is that Conan uses the return of distro.id() to feed it into those dictionaries. But it seems that distro.id() doesn't return endeavouros string, at least my inspection of the distro code. The way to check it would be just import distro + distro.id() in your python in your system.

I had my hard drive fail, its going to take me a bit to get back to you, I will ping you as soon as I am able to, would be back up and running, but I have work, I may not be able to get back to this until this upcoming weekend

[cchulo]

@memsharded sorry for that week-long delay, got around to it, and yes, distro.id() on my OS the method returns correctly:

>>> import distro
>>> distro.id()
'endeavouros'
>>> 

Is it safe to merge this in now?