Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that msys2 bin dir is on PATH for bash #11987

Conversation

jellespijker
Copy link
Contributor

This should prepend the root directory of msys bin dir, on which the bash.exe
is located, as well as tools such as printenv.

Fixes #11986

Changelog: (Bugfix): Ensure that msys2 bin dir is on PATH for bash
Docs: https://github.com/conan-io/docs/pull/XXXX

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

This should prepend the root directory of msys bin dir, on which the bash.exe
is located, as well as tools such as `printenv`.

Fixes conan-io#11986
@jellespijker
Copy link
Contributor Author

@memsharded I think this test might be failing because it doesn't know the all the environmental variables on the PATH in the bash environment. #11981 should take care of that. Do you mind if I merge the branch of that PR into this branch and rerun the tests?

@jellespijker
Copy link
Contributor Author

@memsharded as @SpaceIm correctly stated, the reported issue happened happened due to to a fault on my msys2 recipe which was missing a bindirs I closed the issue and the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] ensure that the msys2 bin folder is added to PATH before calling bash.exe
1 participant