Test source called once for all configurations #12050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czoido
commented
Sep 8, 2022
| @@ -98,40 +98,35 @@ def setUp(self): | |||
| self.client.run("export . --user=conan --channel=stable") | |||
|
|
|||
| def test_source_local_command(self): | |||
| c1 = conanfile % {"no_copy_source": False, "source_with_infos": False, | |||
There was a problem hiding this comment.
source_with_infos was not used any more, as there were two configurations that produced the same package revision but for the second time the source method did not run now the tests failed as a side effect of the changes in the PR
memsharded
approved these changes
Sep 9, 2022
lasote
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like it the source() method is called everytime for each configuration. Testing this does not work properly... and adding a fix