define source_folder in test_package when layout() #12075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasote
reviewed
Sep 12, 2022
| @@ -83,6 +83,7 @@ def deps_install(app, ref_or_path, install_folder, base_folder, graph_info, remo | |||
| conanfile.folders.set_base_install(install_folder) | |||
| conanfile.folders.set_base_imports(install_folder) | |||
| conanfile.folders.set_base_generators(base_folder) | |||
| conanfile.folders.set_base_source(base_folder) | |||
There was a problem hiding this comment.
This would also be assigned when no layout defined. Is that ok?
There was a problem hiding this comment.
I think so, some test_package like the reported one has:
def generate(self):
env = Environment()
env.prepend_path("PKG_CONFIG_PATH", self.source_folder)Will still want the self.source_folder as argument whether the layout() is defined or not. I was exactly trying to see if this could break something because of this.
| cmake_layout(self) | ||
|
|
||
| def generate(self): | ||
| self.output.info("PKG_CONFIG_PATH {}!".format(os.path.exists(self.source_folder))) |
There was a problem hiding this comment.
how is related the PKG_CONFIG_PATH with this change in the code base?
There was a problem hiding this comment.
It is just an example, the original reported issue wanted to set-up the PKG_CONFIG_PATH, but it could be any other message.
czoido
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Define
source_folderin test_package whenlayout()is defined.Docs: Omit
This is a test, to see if something would be broken
Close #12073