Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[develop2]fix aggregation of test trait in diamonds #12080

Merged
merged 1 commit into from
Sep 13, 2022
Merged

[develop2]fix aggregation of test trait in diamonds #12080

merged 1 commit into from
Sep 13, 2022

Conversation

memsharded
Copy link
Member

If there are diamonds in host context mixing test and non test requirements, the test=False should prevail, so filters like dependencies.host find it.

@memsharded memsharded added this to the 2.0.0-beta4 milestone Sep 12, 2022
@memsharded memsharded marked this pull request as ready for review September 12, 2022 12:27
@lasote lasote merged commit 043419e into conan-io:develop2 Sep 13, 2022
@memsharded memsharded deleted the fix/develop2_test_trait_aggregate branch September 13, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasote lasote lasote approved these changes

Assignees

@lasote lasote

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta4
Development

Successfully merging this pull request may close these issues.
2 participants
@memsharded @lasote