-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meson] Meson appending extra machine files #12117
[Meson] Meson appending extra machine files #12117
Conversation
@@ -8,7 +7,6 @@ | |||
|
|||
|
|||
@pytest.mark.tool_meson | |||
@pytest.mark.skipif(sys.version_info.major == 2, reason="Meson not supported in Py2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No python2x anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not convinced that the user story is injecting some meson files to all meson projects, or the users are missing a "local" way to inject those files inside package recipes, but like a different file for each project. I don't know enough about Meson usage and patterns, but we need to think about it.
""") | ||
myfilename = textwrap.dedent(""" | ||
[binaries] | ||
c = '/usr/fake/path/gcc' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The definition of compilers might be "standardized" by Conan in its own configuration (or handle env-var CC CXX for everyone), so maybe not a good example
From a documentation perspective, what is a meson "user filename"? Shouldn't this use a name more evocative of the fact that Meson calls them native machine files? |
But there are |
1bb6bb3
to
6036ade
Compare
I've changed the configuration name to |
Changed to |
6036ade
to
fff6535
Compare
Changelog: Feature: Add
tools.meson.mesontoolchain:extra_machine_files=["FILENAMES"]
toMeson
build helper to append machine files to the the ones created by Conan.Docs: conan-io/docs#2831
Closes: #11961