add support for windows on ARM64 native platform #12145
Conversation
| @@ -442,6 +442,11 @@ def vcvars_command(conanfile=None, arch=None, compiler_version=None, force=False | |||
| 'x86_64': 'x86_amd64', | |||
| 'armv7': 'x86_arm', | |||
| 'armv8': 'x86_arm64'}.get(arch_setting) | |||
| elif arch_build == 'armv8': | |||
There was a problem hiding this comment.
This is modifying only the legacy tool from conans
This should be done as a secondary thing, as a backport, but this should be addressed first in from conan space.
Also some unittest would be necessary, please ask for guidance if you need it.
Thanks for contributing to Conan!
There was a problem hiding this comment.
Thank you for the pointers. I've added the same code also for non-legacy from conan.
I've also updated the only unit test I found that deals with testing the vcvars, but it also works with the legacy from conans. Also, how to run just this single test? I've run python3 -m tox -e full as described in the documentation and more than 1400 tests have failed, most of them completely unrelated to my change. Are they supposed to fail?
Co-authored-by: James <james@conan.io>
Co-authored-by: James <james@conan.io>
Changelog: Fix: Add support for windows on ARM64 native platform.
Docs: omit
Closes: #12144