Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make conan.tools.scmGit.run() public #12165

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Make conan.tools.scmGit.run() public #12165

merged 2 commits into from
Sep 21, 2022

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Sep 21, 2022 •
edited
Loading

Changelog: Feature: Make conan.tools.scmGit.run() public.
Docs: conan-io/docs#2762

Closes: #12124

@czoido czoido added this to the 1.53 milestone Sep 21, 2022
memsharded
memsharded approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test that runs git.run("something") in the recipe code, to make sure this doesn't break in the future.

@memsharded memsharded merged commit 54f1221 into conan-io:develop Sep 21, 2022
@memsharded memsharded mentioned this pull request Sep 21, 2022
Closed
5 tasks
@czoido czoido mentioned this pull request Sep 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.53
Development

Successfully merging this pull request may close these issues.
2 participants
@czoido @memsharded