Follow conventions for Conan 2.0 CLI output #12235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czoido
changed the title
czoido
commented
Oct 5, 2022
memsharded
reviewed
Oct 5, 2022
conan/cli/commands/__init__.py
Outdated
| myjson = json.dumps(data, indent=4, cls=ConanJSONEncoder) | ||
| return myjson | ||
| ConanOutput(stream=sys.stdout).writeln(myjson) |
There was a problem hiding this comment.
I am not sure about this. We were discussing about how ConanOutput was always for our messages to stderr, while we would use other things for stdout. Becaye also there is extra configurations, like loggers or the logger-as-json that can affect how the ConanOutput behaves, and that would be bad for the stdout output, wouldn't it?
There was a problem hiding this comment.
Ok, I see, then probably what needs to be used is cli_out_write (we can change the name later perhaps), I'll make the changes and we see from there
czoido
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still working on it ...
Following the convention for Conan 2.0 that the results for the commands are dumped to the stdout. Rest of operations while running the command are dumped to stderr.
Several fixes in the output for the CLI:
textformatter if they have to output something to the stdout.textformatter is not shown in the help and is used by default in case the command defined it.I think that the formatters were not correctly used in the code because they only formatted the output and not write anything and maybe that was a bit confusing, so now the formatters are changed to also do the actual output to stdout using
cli_out_write()