Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[develop2] Simplifying compress/uncompress #12378

Merged
merged 4 commits into from
Nov 11, 2022
Merged

[develop2] Simplifying compress/uncompress #12378

merged 4 commits into from
Nov 11, 2022

Conversation

memsharded
Copy link
Member

Simplifying the code, because now, obtaining exactly the same .tgz is no longer critical, as Conan 2.0 it is driven by the revision, and not the actual checksum of the .tgz

  • The compression was doing some tricks with symlinks plus modifying some file flags, trying to not do it.
  • While unzipping it was checking if there were absolute paths (this should never happen, Conan create the .tgz itself), and if they contain backslash
  • Removing the touch to update the files timestamps when unzipping .tgzs

Close #2729

@memsharded memsharded requested review from czoido and jcar87 October 23, 2022 23:58
@memsharded memsharded added this to the 2.0.0-beta5 milestone Oct 23, 2022
@memsharded memsharded mentioned this pull request Nov 8, 2022
Closed
@czoido czoido marked this pull request as ready for review November 11, 2022 10:43
@memsharded memsharded merged commit a132411 into conan-io:develop2 Nov 11, 2022
@memsharded memsharded deleted the feature/keep_timestamps branch November 11, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czoido czoido czoido approved these changes

@jcar87 jcar87 jcar87 approved these changes

Assignees

@jcar87 jcar87

Labels
type: look into
Projects
None yet
Milestone
2.0.0-beta5
Development

Successfully merging this pull request may close these issues.
3 participants
@memsharded @jcar87 @czoido