Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix auto_use=True crash with no generate() #12386

Merged
merged 1 commit into from
Oct 25, 2022
Merged

fix auto_use=True crash with no generate() #12386

merged 1 commit into from
Oct 25, 2022

Conversation

memsharded
Copy link
Member

Changelog: Bugfix: Avoid Conan crash when tools.env.environment:auto_use=True is enabled and no generate() method.
Docs: Omit

Close #12383

@memsharded memsharded added this to the 1.54 milestone Oct 24, 2022
@memsharded memsharded requested a review from uilianries October 24, 2022 16:19
uilianries
uilianries approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czoido czoido merged commit 883eff8 into conan-io:develop Oct 25, 2022
@memsharded memsharded deleted the fix/auto_use_crash branch October 25, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czoido czoido czoido approved these changes

@uilianries uilianries uilianries approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
1.54
Development

Successfully merging this pull request may close these issues.

[bug] Header-only packages can't be created without an empty generate method when using a layout
3 participants
@memsharded @uilianries @czoido