Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcrun settings #12486

Merged
merged 3 commits into from
Nov 8, 2022
Merged

xcrun settings #12486

merged 3 commits into from
Nov 8, 2022

Conversation

paulocoutinhox
Copy link
Contributor

@paulocoutinhox paulocoutinhox commented Nov 8, 2022

Changelog: Feature: Make available XCRun().settings read attribute.
Docs: conan-io/docs#2829

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small unittest, or adding a check in some existing test would be good to capture the behavior and avoid breaking this in the future.

conans/client/migrations_settings.py Show resolved Hide resolved
@memsharded memsharded added this to the 1.55 milestone Nov 8, 2022
@czoido
Copy link
Contributor

czoido commented Nov 8, 2022

Sorry, I have just seen this, these changes were just pushed to develop, closing this. Thanks a lot @paulocoutinhox

@czoido czoido closed this Nov 8, 2022
@czoido czoido removed this from the 1.55 milestone Nov 8, 2022
@memsharded memsharded added this to the 1.55 milestone Nov 8, 2022
@czoido czoido reopened this Nov 8, 2022
@czoido
Copy link
Contributor

czoido commented Nov 8, 2022

Sorry @paulocoutinhox,
I just saw the last commit changes and closed the PR, reopening it.

@memsharded memsharded merged commit 8e12b98 into conan-io:develop Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants