Fix passing build jobs number (-j) to Autotools build helper #12505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czoido
changed the title
1 task
SpaceIm
reviewed
Nov 10, 2022
memsharded
reviewed
Nov 10, 2022
conan/tools/gnu/autotools.py
Outdated
| @@ -48,16 +49,19 @@ def make(self, target=None, args=None): | |||
| str_args = self._make_args | |||
| str_extra_args = " ".join(args) if args is not None else "" | |||
| jobs = "" | |||
| if "-j" not in str_args and "nmake" not in make_program.lower(): | |||
| jobs_already_passed = re.search(r"-j(\d+)", join_arguments([str_args, str_extra_args])) | |||
There was a problem hiding this comment.
I am not sure if this should be expected. The moment Conan has a standard, defined mechanism to customize the paralelism, this shouldn't be taken into account:
- The profile
njobsshould have priority to what the recipe says. In general, anything defined in the profiles should have priorities - Why would a recipe hardcoded the number of cores it is using in a custom
argin the helper?
There was a problem hiding this comment.
Install target doesn't always support multiprocessing in Makefiles (there are examples in conan-center), so recipe must ensure robust installation regardless of njobs in profile.
SpaceIm
reviewed
Nov 10, 2022
SpaceIm
reviewed
Nov 10, 2022
memsharded
approved these changes
Nov 15, 2022
franramirez688
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Give priority to
-jargument set by user in recipe over the default set by conan inAutotoolsbuild helper.Docs: omit
Closes: #12494
Closes: #12296