Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/nmakedeps #12599

Merged
merged 3 commits into from
Nov 24, 2022
Merged

Feature/nmakedeps #12599

merged 3 commits into from
Nov 24, 2022

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Nov 24, 2022 •
edited
Loading

Changelog: Feature: New NMakeDeps generator.
Docs: conan-io/docs#2828

Close #12188

@memsharded memsharded added this to the 1.55 milestone Nov 24, 2022
@memsharded memsharded marked this pull request as ready for review November 24, 2022 14:06
franramirez688
franramirez688 approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@franramirez688 franramirez688 merged commit 68d38fb into conan-io:develop Nov 24, 2022
@memsharded memsharded deleted the feature/nmakedeps branch November 24, 2022 17:12
@memsharded memsharded mentioned this pull request Nov 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franramirez688 franramirez688 franramirez688 approved these changes

Assignees

@franramirez688 franramirez688

Labels
None yet
Projects
None yet
Milestone
1.55
Development

Successfully merging this pull request may close these issues.

[question] Is there a conan v2 build helper to honor profile in nmake builds?
2 participants
@memsharded @franramirez688