Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop2] refactor around cli and api #12615

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

memsharded
Copy link
Member

Pure refactors, no functional change:

  • Renamed ConanAPIV2 -> ConanAPI (it is confusing for the users to mix 2.0 version with api version, this is the first public documented api)
  • Moved _get_conanfile_path() helper, used in many places to its own LocalAPI api. It seems there are other bits of code that we will have to find a location for them, and LocalAPI could be good. We could discuss if editable api could be part of this, maybe yes
  • Moved deployers code from api to its own internal deploy.py module
  • Moved some helpers related to CLI arguments to args.py

TODO: (in another PR). Find a place to the global graph_compute() function, used in multiple commands.

@memsharded memsharded added this to the 2.0.0-beta6 milestone Nov 28, 2022
@memsharded memsharded marked this pull request as ready for review November 28, 2022 09:55
@czoido czoido merged commit 2ff7ce9 into conan-io:develop2 Nov 28, 2022
@memsharded memsharded deleted the refactor/api_cli branch November 28, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants