-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutotoolsToolchain] Added self.xxxx_options
#12645
[AutotoolsToolchain] Added self.xxxx_options
#12645
Conversation
I think it breaks existing conan-center recipes which have to replace |
FYI, in conan-center there are currently several recipes migrated to
It's worth noting that most of these recipes have to replace |
target
calculation and configure_args
initializedtarget
calculation and update_xxxx_args
helper functions
1f76319
to
15d517c
Compare
target
calculation and update_xxxx_args
helper functionsself.xxxx_options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not fully clear why the new approach do not replace the previous one, and there are smart conversions between the two of them.
Superseded by #12884 (less risky approach). |
Changelog: Feature: Added new attributes (Python dict) to
AutotoolsToolchain
:self.configure_options
,self.autoreconf_options
, andself.make_options
.Changelog: Feature: Added new attribute
AutotoolsToolchain.use_new_options
(boolean) to keep backward compatibility.Changelog: Feature:
AutotoolsToolchain.xxxxx_args
are adequately initialized.Changelog: Bugfix:
AutotoolsToolchain.configure_args
was overwriting Conan's pre-calculated arguments.Docs: https://github.com/conan-io/docs/pull/XXXX
Closes: #12431
Closes: #12642
Closes: #12705
Closes: #12546
Summary:
AutotoolsToolchain.xxxx_args
attributes (lists) in favor ofAutotoolsToolchain.xxxxx_options
ones (dicts).AutotoolsToolchain.use_new_options
(bool) attr. Notice that it should disappear in the future whenxxxx_args
won't be used.