Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better error UX when spaces are found in required_conan_version #12695

Conversation

AbrilRBS
Copy link
Member

Changelog: (Fix): Display a better error when required_conan_version has spaces between the operator and the version.

This used to never allow the version check, even if the error was in the syntax, so now we just give a better error message

Closes #12692

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@AbrilRBS AbrilRBS requested a review from memsharded December 12, 2022 16:38
@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
All committers have signed the CLA.

@memsharded memsharded added this to the 2.0.0-beta7 milestone Dec 12, 2022
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@memsharded memsharded merged commit fd8d17b into conan-io:develop2 Dec 12, 2022
@AbrilRBS AbrilRBS deleted the rr/better_error_for_spaces_in_required_conan_version branch December 23, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants