[develop2] Improve a bit the output msgs #12746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add progress to the output of package installation process
AbrilRBS
approved these changes
Feb 20, 2023
| @@ -200,6 +208,7 @@ def write_cmake_presets(conanfile, toolchain_file, generator, cache_variables, | |||
|
|
|||
| preset_content = json.dumps(data, indent=4) | |||
| save(preset_path, preset_content) | |||
| ConanOutput(str(conanfile)).info("CMakeToolchain generated: CMakePresets.json") | |||
There was a problem hiding this comment.
I'm guessing these are ConanFileInterfaces and that's why they can't just call conanfile.output..., right?
There was a problem hiding this comment.
No, good catch, I think this might be a full conanfile, this might be replaced by conanfile.output.info
czoido
approved these changes
Feb 20, 2023
franramirez688
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Improved global Conan output messages (create, install, export, etc.)
Docs: omit