Fixing cmake_layout single config #12829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSE4
reviewed
Jan 4, 2023
| @@ -49,17 +50,11 @@ def get_build_folder_custom_vars(conanfile): | |||
| default=[], check_type=list) | |||
| ret = [] | |||
| for s in build_vars: | |||
| group, var = s.split(".", 1) | |||
There was a problem hiding this comment.
what if it doesn't have a dot, will it raise with a weird exception here?
There was a problem hiding this comment.
Yes, but that was already happening before, nothing new, and I didn't want to add extra noise and tests, as this PR is already quite potentially breaking.
czoido
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Make
cmake_layoutto use single-config folder for generated files.Docs: conan-io/docs#2891
Close #12827