-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional requirements fields to all templates #12830
Add optional requirements fields to all templates #12830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some test might be failing for changed hashes of contents (you might avoid it by avoiding extra blank lines in the template if requires not defined)
Oops, I thought I had submitted this as a draft. I knew about the failing tests and wanted to fix it before un-drafting it, but I guess it's too late now for it now that you've reviewed it @memsharded 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with merging this, and postponing the implementation of real include and linking and executing dependencies for a later PR, and maybe not necessary to do it at once for all templates, but one at a time also good (maybe it would have been better to introduce the new requires
in templates one at a time while implementing the whole functionality, but I am fine with it too this way)
After talking with @czoido and @memsharded, let's rethink how we approach this and merge something minimal, and then create a cmake template that works, and we can then add more interesting stuff such as the toy example suggested by Carlos |
Changelog: (Feature): Add optional requirements fields to all templates
Docs: conan-io/docs#2881
Just as for the basic template, this now lets you add multiple requirements to your templates if needed, such as:
conan new cmake_exe -d name=game -d version=1.0 -d requires=maths/1.3 -d requires=ai/2.0
Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.