Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop2] remove PID timestamps in conan list #12871

Closed
wants to merge 8 commits into from

Conversation

memsharded
Copy link
Member

Refactoring conan list tests, removing timestamps of PID in output

Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, it's looking good! I agree with the temporal timestamps solution to return the same results for both cache and remote 😀

if prefs:
for pref, binary_info in prefs:
pref_ret[pref.repr_notime()] = binary_info
ret[ref.repr_notime()] = pref_ret
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done to avoid failures when converting to JSON. I guess that test test_list_package_info_and_json_format was lost.

@franramirez688 franramirez688 linked an issue Jan 9, 2023 that may be closed by this pull request
@memsharded
Copy link
Member Author

Superseded by #12883

@memsharded memsharded closed this Jan 11, 2023
@memsharded memsharded deleted the test/develop2_list branch January 11, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] [develop2] conan list output different
2 participants