-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop2] remove PID timestamps in conan list
#12871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see, it's looking good! I agree with the temporal timestamps solution to return the same results for both cache and remote 😀
if prefs: | ||
for pref, binary_info in prefs: | ||
pref_ret[pref.repr_notime()] = binary_info | ||
ret[ref.repr_notime()] = pref_ret |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done to avoid failures when converting to JSON. I guess that test test_list_package_info_and_json_format
was lost.
Superseded by #12883 |
Refactoring
conan list
tests, removing timestamps of PID in output