Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop2] Propose new settings_user.yml #12980

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jan 26, 2023

Changelog: Feature: Users can define their own settings in settings_user.yml that will be merged with the Conan settings.yml.

Close #8261
Close #12422

The main blocker for #8261 was the idea that it is necessary to do the round-trip for the yml file. It seems that is more doable to update the in-memory dictionaries, this is a proof of concept.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@memsharded memsharded requested a review from jcar87 January 27, 2023 09:39
@memsharded memsharded marked this pull request as ready for review January 29, 2023 22:28
@czoido czoido merged commit 5421bf2 into conan-io:develop2 Jan 31, 2023
@memsharded memsharded deleted the feature/develop2_user_settings branch January 31, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants