-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create summary of cached content #13386
Create summary of cached content #13386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Not sure what would be the best flow, if we should merge, or we should target "develop2" for 2.1, or how to approach it. Ideally, this part of the cache could start to be used asap I guess
h = sha256 | ||
sources_cache = True | ||
else: | ||
ConanOutput()\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for ourselves: we need modes of behavior for the caching, like being able to raise if the thing is not cached, to raise if it cannot be cached because of no sha256, etc. For future work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to always use "unknown" as an origin if the ref is None, and added a test path for when the ref is actually there, but have a question about the usage of the --format=json
output
Changelog: Feature: Create summary of cached content.
Docs: Omit
Co-Authored-By: @memsharded
Initial work towards the sources backup feature, this PR aims to implement a simple "summary.json" for sources downloaded by a conanfile, which stores info about which reference downloaded which URL, relying in the sha256 checksum as the key.
It also changes the cache layout a bit by moving the mentioned downloaded files by the conanfile to their own
s/
subfolder, and the rest toc/
Omitted docs because it only makes sense to document this once the whole feature lands