Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic package filter for conan list html output #13470

Merged
merged 7 commits into from
Mar 17, 2023
Merged

Add basic package filter for conan list html output #13470

merged 7 commits into from
Mar 17, 2023

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Mar 17, 2023 •
edited
Loading

Changelog: Feature: Add filtering for options and settings in conan list html output.
Docs: omit

This is also passing the arguments from the cli to show the input in the top navbar in the html

image

@czoido czoido added this to the 2.0.3 milestone Mar 17, 2023
@czoido czoido marked this pull request as draft March 17, 2023 09:54
@czoido czoido marked this pull request as ready for review March 17, 2023 10:54
memsharded
memsharded reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

html and functionality looks good, but I'd move the cli_args to the conan list command exclusively

conan/cli/command.py Outdated Show resolved Hide resolved
@memsharded memsharded merged commit d1905b7 into conan-io:release/2.0 Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded left review comments

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@czoido @AbrilRBS @memsharded