Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new move_folder_contents() file helper to re-arrange repos #13509

Merged
merged 2 commits into from
Mar 24, 2023

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Mar 23, 2023

Changelog: Feature: New move_folder_contents() file helper to re-arrange repos folders.
Docs: conan-io/docs#3196
Close #12360

This was already private internal to implement some tests, but tests are a public use case, so it should be made public, I have refactored, improved, and added more tests for this helper.

@memsharded memsharded added this to the 1.60 milestone Mar 23, 2023
@memsharded memsharded self-assigned this Mar 23, 2023
@memsharded memsharded requested a review from AbrilRBS March 23, 2023 00:02
# Remove potential "siblings" folders not wanted
src_folder_name = os.path.basename(src_folder)
for f in os.listdir(dst_folder):
if f != src_folder_name: # FIXME: Only works for 1st level subfolder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was checking if os.walk would work for this fixme, but it's trickier than that

@czoido czoido merged commit 7ef5ade into conan-io:develop Mar 24, 2023
@memsharded memsharded deleted the feature/move_folder_contents branch March 30, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants